Repository navigation
gh-152325: Gate curses.has_mouse() on the ncurses patch level - #152652
Merged
serhiy-storchaka merged 1 commit intoJun 30, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
has_mouse() was added to ncurses after the 5.7 release, but the binding guarded it only with NCURSES_MOUSE_VERSION, which 5.7 already defines, so the module failed to compile against ncurses 5.7 (such as the system curses on macOS). Gate it additionally on NCURSES_EXT_FUNCS, which holds the library's patch date. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
Documentation build overview1 file changed ± library/curses.html |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildbot fix for gh-152325.
has_mouse() was added to ncurses after the 5.7 release (2008-11-22), but the binding guarded it only with NCURSES_MOUSE_VERSION, which 5.7 already defines. On ncurses 5.7 — such as the system curses on macOS — has_mouse() is undeclared, and with clang treating implicit declarations as errors _cursesmodule.c failed to compile, breaking a number of buildbots.
Gate has_mouse() additionally on NCURSES_EXT_FUNCS, which holds the library's patch date when extended functions are enabled (the default), matching the existing is_cleared/is_cbreak guards.
wmouse_trafo()/mouse_trafo() need no guard — they are the same vintage as wenclose()/enclose(), which already compile on those buildbots.