Repository navigation
gh-154686: Add text_len to TextWrapper - #152702
Open
kdeldycke wants to merge 1 commit into
Open
kdeldycke wants to merge 1 commit into
kdeldycke wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
kdeldycke
requested review from
AA-Turner,
savannahostrowski and
terryjreedy
as code owners
June 30, 2026 15:34
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
This was referenced Jun 30, 2026
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jun 30, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
21c6877 to
4497db3
Compare
June 30, 2026 15:37
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jun 30, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
4497db3 to
baba0c5
Compare
June 30, 2026 15:40
This was referenced Jun 30, 2026
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jun 30, 2026
# Conflicts: # Doc/whatsnew/3.16.rst
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
baba0c5 to
36a27ac
Compare
June 30, 2026 16:06
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jun 30, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
36a27ac to
ac1a642
Compare
June 30, 2026 16:07
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jun 30, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
ac1a642 to
090c887
Compare
June 30, 2026 16:10
Copy link
Copy Markdown
Documentation build overview149 files changed · + 3 added · ± 146 modified + Added ± Modified |
Sorry, something went wrong.
merwok
reviewed
Jul 13, 2026
Comment thread
Doc/library/textwrap.rst
Outdated
merwok
reviewed
Jul 13, 2026
Comment thread
Lib/test/test_textwrap.py
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jul 15, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
8327c94 to
ba63d75
Compare
July 15, 2026 23:34
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jul 15, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
219db60 to
8e3c15a
Compare
July 15, 2026 23:45
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jul 25, 2026
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
8e3c15a to
3cdc69f
Compare
July 25, 2026 09:49
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jul 25, 2026
For ANSI and variable character width awareness. Removes local patch introduced in python#154634.
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
3cdc69f to
847d242
Compare
July 25, 2026 10:19
kdeldycke
added a commit
to kdeldycke/cpython
that referenced
this pull request
Jul 25, 2026
For ANSI and variable character width awareness. Removes local patch introduced in python#154634.
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
847d242 to
1497de0
Compare
July 25, 2026 11:47
For ANSI and variable character width awareness. Removes local patch introduced in python#154634.
kdeldycke
force-pushed
the
ANSI-aware-TextWrapper
branch
from
4f1e56d to
27b653d
Compare
July 31, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a text_len parameter to textwrap.wrap, textwrap.fill, textwrap.shorten and textwrap.TextWrapper. It customizes how the visible width of a string is measured, so text that contains zero-width or double-width characters, or invisible ANSI escape sequences, can be wrapped correctly.
This has the side effect of removing the local patch in _split_lines introduced by #154634 .
Context
I am a maintainer of Click and had to maintain my own local fork of TextWrapper to make it strip ANSI strings properly. See my initial code at: pallets/click#3420 . This PR is a direct port of that code to Python standard library.
This PR: