[3.15] gh-152502: Detect the curses mouse interface portably (GH-152705) - #152707
Merged
serhiy-storchaka merged 1 commit intoJun 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ythonGH-152705) The mouse interface (getmouse(), the BUTTON* constants, ...) was gated on the ncurses-specific NCURSES_MOUSE_VERSION macro, so it was dropped on other curses implementations that provide it, such as NetBSD curses and PDCurses. Gate it instead on a configure capability probe or the PDCURSES macro. Probe for getmouse() with its X/Open getmouse(MEVENT *) signature, since PDCurses declares an incompatible getmouse(void) unless built for the ncurses mouse API, which PDC_NCMOUSE now always selects. The is_*() state-query methods named in the original change do not exist on 3.15, so only the mouse interface is backported. (cherry picked from commit 7bbea4f) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
June 30, 2026 20:13
This was referenced Jun 30, 2026
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 83391ceff61bdc5d0ba994cdae23f1406885825c 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 83391ceff61bdc5d0ba994cdae23f1406885825c 3.13 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mouse interface (getmouse(), the BUTTON* constants, ...) was gated on the ncurses-specific NCURSES_MOUSE_VERSION macro, so it was dropped on other curses implementations that provide it, such as NetBSD curses and PDCurses (the latter underpins windows-curses).
It is now gated on a configure capability probe or the PDCURSES macro. getmouse() is probed with its X/Open getmouse(MEVENT *) signature specifically, because PDCurses declares an incompatible getmouse(void) unless built for the ncurses mouse API; PDC_NCMOUSE is now always defined so PDCurses selects that interface.
The is_*() state-query methods named in the original change (GH-152705) do not exist on 3.15, so only the mouse interface is backported.
Verified by reconfiguring + rebuilding on 3.15 (the probe resolves HAVE_CURSES_GETMOUSE=1) and running test_curses.
(cherry picked from commit 7bbea4f)