gh-152682: Remove useless test_syntax.test_disallowed_type_param_names_oom - #152770
Merged
StanFromIreland merged 1 commit intoJul 1, 2026
Merged
gh-152682: Remove useless test_syntax.test_disallowed_type_param_names_oom#152770StanFromIreland merged 1 commit into
StanFromIreland merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The regression test has been removed because it was non-functional. The previous fix for this issue is covered by `test_disallowed_type_param_names()`. Tests are not required for fixes of this kind. Signed-off-by: Petr Vaganov <petrvaganoff@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Please add skip news because news was added in previous commit in this issue. |
Sorry, something went wrong.
2 tasks
Copy link
Copy Markdown
Contributor
Author
|
Also, could you please advise on how to handle these backports? Should we merge them first and then backport this pull request? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
We can cherry-pick to the backports, we don't need to merge in unnecessary tests just to remove them shortly after. |
Sorry, something went wrong.
StanFromIreland
approved these changes
Jul 1, 2026
Copy link
Copy Markdown
Contributor
Author
|
Okay, thank you for the help. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test has been removed because it was non-functional. The previous fix for this issue is covered by test_disallowed_type_param_names(). Tests are not required for fixes of this kind.
Since the main pull request has already been merged, I’ve opened a new one to remove the test.
Context: comment from @StanFromIreland
#152684 (comment)