FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.14] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916) by miss-islington · Pull Request #152917 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.14] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916) - #152917

Merged
terryjreedy merged 1 commit into
python:3.14from
miss-islington:backport-984ebbf-3.14
Jul 2, 2026
ConversationCommits (1)ChecksFiles changed
Merged

[3.14] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916)#152917
terryjreedy merged 1 commit into
python:3.14from
miss-islington:backport-984ebbf-3.14

Conversation

miss-islington commented Jul 2, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 984ebbf)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

[3.15] pythongh-151428: Remove unused imports in idlelib.idle_test (p…
887cfb8 
…ythonGH-151478) (pythonGH-152916)

(cherry picked from commit 984ebbf)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
bedevere-app Bot mentioned this pull request Jul 2, 2026
Closed
bedevere-app Bot mentioned this pull request Jul 2, 2026
Merged
terryjreedy enabled auto-merge (squash) July 2, 2026 21:27

terryjreedy commented Jul 2, 2026

Copy link
Copy Markdown
Member

@serhiy-storchaka This 3.14 (only) backport of a trivial IDLE change has an unrelated test_tkinter failure.
macOS / build and test (macos-15-intel)
2026-07-02T21:17:33.0812420Z ======================================================================
2026-07-02T21:17:33.0814540Z �[31mFAIL�[0m�[1;31m: test_boundary_values_accepted (test.test_tkinter.test_simpledialog.QueryDialogTest.test_boundary_values_accepted)�[0m
2026-07-02T21:17:33.0816210Z ----------------------------------------------------------------------
2026-07-02T21:17:33.0816980Z Traceback (most recent call last):
2026-07-02T21:17:33.0818680Z File �[35m"/Users/runner/work/cpython/cpython/Lib/test/test_tkinter/test_simpledialog.py"�[0m, line �[35m244�[0m, in �[35mtest_boundary_values_accepted�[0m
2026-07-02T21:17:33.0820420Z �[31mself.assertEqual�[0m�[1;31m(d.result, 10)�[0m
2026-07-02T21:17:33.0821200Z �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^�[0m
2026-07-02T21:17:33.0821950Z �[1;35mAssertionError�[0m: �[35mNone != 10�[0m
2026-07-02T21:17:33.0822410Z
2026-07-02T21:17:33.0823790Z ======================================================================
2026-07-02T21:17:33.0825720Z �[31mFAIL�[0m�[1;31m: test_return_no_default (test.test_tkinter.test_simpledialog.SimpleDialogTest.test_return_no_default)�[0m
2026-07-02T21:17:33.0827240Z ----------------------------------------------------------------------
2026-07-02T21:17:33.0828240Z Traceback (most recent call last):
2026-07-02T21:17:33.0830340Z File �[35m"/Users/runner/work/cpython/cpython/Lib/test/test_tkinter/test_simpledialog.py"�[0m, line �[35m68�[0m, in �[35mtest_return_no_default�[0m
2026-07-02T21:17:33.0833220Z �[31mself.assertTrue�[0m�[1;31m(bells)�[0m # rang the bell
2026-07-02T21:17:33.0834560Z �[31m~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^�[0m
2026-07-02T21:17:33.0835520Z �[1;35mAssertionError�[0m: �[35m[] is not true�[0m

re-running

terryjreedy merged commit 8a2e34c into python:3.14 Jul 2, 2026
84 of 86 checks passed
miss-islington deleted the backport-984ebbf-3.14 branch July 2, 2026 21:52

terryjreedy commented Jul 2, 2026

Copy link
Copy Markdown
Member

Rerun passed; possible timing error.

terryjreedy added the needs backport to 3.13 only security fixes label Jul 3, 2026

miss-islington-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Sorry, @miss-islington and @terryjreedy, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a2e34c9e002d85d81ed0f1c92cf7ed5c99a04ae 3.13

serhiy-storchaka commented Jul 15, 2026

Copy link
Copy Markdown
Member

Please don't forget about backports.

hugovk commented Jul 29, 2026

Copy link
Copy Markdown
Member

No backport needed, these imports aren't in 3.13:

hugovk removed the needs backport to 3.13 only security fixes label Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL