Repository navigation
[3.13] gh-89520: Load extension settings and keybindings from user config (GH-28713) (GH-152992) - #152993
Merged
terryjreedy merged 1 commit intoJul 4, 2026
Merged
[3.13] gh-89520: Load extension settings and keybindings from user config (GH-28713) (GH-152992)#152993terryjreedy merged 1 commit into
terryjreedy merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ser config (pythonGH-28713) (pythonGH-152992) Extension keybindings defined in ~/.idlerc/config-extensions.cfg were silently ignored because GetExtensionKeys, __GetRawExtensionKeys, and GetExtensionBindings only checked default config. Fix these to check user config as well, and update the extensions config dialog to handle user-only extensions correctly. --------- (cherry picked from commit 8a8c8ee) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org> (cherry picked from commit 208195d)
This was referenced Jul 4, 2026
Copy link
Copy Markdown
Documentation build overview465 files changed · + 1 added · ± 424 modified · - 40 deleted + Added ± Modified
- Deleted |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension keybindings defined in ~/.idlerc/config-extensions.cfg
were silently ignored because GetExtensionKeys, __GetRawExtensionKeys,
and GetExtensionBindings only checked default config.
Fix these to check user config as well, and update the extensions config
dialog to handle user-only extensions correctly.
(cherry picked from commit 8a8c8ee)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com
Co-authored-by: Gregory P. Smith greg@krypto.org
(cherry picked from commit 208195d)