FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-153009: Fix compilation of `curses` on platforms that define the `stdscr` macro by picnixz · Pull Request #153010 · python/cpython · GitHub

Repository navigation

gh-153009: Fix compilation of curses on platforms that define the stdscr macro - #153010

Merged
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/curses/build-153009
Jul 4, 2026
Merged

picnixz merged 2 commits into
python:mainfrom
picnixz:fix/curses/build-153009

Conversation

picnixz commented Jul 4, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are fast! LGTM. 👍

picnixz commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

I was fast because I needed that patch for another PR. It was a matter of splitting local work :')

Copy link
Copy Markdown
Member

One small naming thought: std_screen reads a bit oddly since the field holds the stdscr window object inside a struct that's already a …ScreenObject — something like stdscr_win or std_win would say what it holds without colliding with the macro. Purely cosmetic, so feel free to keep std_screen if you prefer it.

picnixz commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

I like the stdscr_win

picnixz merged commit cfe3e07 into python:main Jul 4, 2026
54 checks passed
picnixz deleted the fix/curses/build-153009 branch July 4, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL