Repository navigation
gh-59598: Strip leading whitespace in JSONDecoder.raw_decode - #153017
Closed
mayank-dev-15 wants to merge 1 commit into
Closed
mayank-dev-15 wants to merge 1 commit into
mayank-dev-15 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
raw_decode currently ignores leading whitespace before JSON values,
raising JSONDecodeError on strings like ' {"key": "value"}'. This is
inconsistent with JSONDecoder.decode() which handles leading whitespace.
Add s = s.lstrip() at the start of raw_decode to strip leading
whitespace before decoding, matching the behavior of decode().
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59598
JSONDecoder.raw_decode() raises JSONDecodeError on strings with leading whitespace (e.g., ' {"key": "value"}'), while JSONDecoder.decode() handles it fine. This is inconsistent behavior.
Changes
Add s = s.lstrip() at the start of raw_decode() to strip leading whitespace before decoding, matching the behavior of decode().
Test
This matches the behavior of decoder.decode(' {"key": "value"}') which already works correctly.