Repository navigation
gh-151757: Skip curses variation-selector test on older macOS - #153344
Merged
serhiy-storchaka merged 1 commit intoJul 9, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Older macOS reports a variation selector as a spacing character (wcwidth() returns 1) instead of a zero-width combining mark, so curses cannot put it in the same cell as its base. Skip that assertion there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
|
Wow, thanks for such a quick fix! I will give it a try tomorrow and get back to you soon. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi, I have verified that the fix works for me :) >>> platform.mac_ver()
('14.2', ('', '', ''), 'arm64')
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thank you for verification. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older macOS reports a variation selector as a spacing character (wcwidth() returns 1) instead of a zero-width combining mark, so curses cannot place it in the same cell as its base character and test_addch_emoji raises ValueError.
curses groups cells by wcwidth(), the same as ncurses, so the assertion is only valid where the platform reports the selector as zero-width; skip it elsewhere.
The failure is confirmed on macOS 14.2 (reported in the issue) and gone by macOS 26, which CI runs, so 26 is the conservative cutoff.
🤖 Generated with Claude Code