Repository navigation
gh-151292: Change total_samples:u32 in the binary format to total_samples:u64 - #153425
Merged
pablogsal merged 2 commits intoJul 9, 2026
Merged
pablogsal merged 2 commits into
pablogsal merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pablogsal
approved these changes
Jul 9, 2026
Copy link
Copy Markdown
Member
|
Great work! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-153436 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR bumps total_samples:u32 from the binary format to total_samples:u64. The reason for doing so is that, as per #151292, u32 under 10khz is sufficient only for:
That might look a bit excessive but with continous profiling of production systems it's totally possible to see 1Khz and a couple of threads, a couple of days.
This change breaks backwards compatibility, but - as per discussion offline - we're before rc1 so it should be OK, and NOW is the best time to do such change.