FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-30335: Add deprecation alias entry for assertNotRegexpMatches by DimitrisJim · Pull Request #1536 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-30335: Add deprecation alias entry for assertNotRegexpMatches - #1536

Merged
Mariatta merged 4 commits into
python:masterfrom
DimitrisJim:issue30335
Jun 9, 2017
ConversationCommits (4)ChecksFiles changed
Merged

bpo-30335: Add deprecation alias entry for assertNotRegexpMatches#1536
Mariatta merged 4 commits into
python:masterfrom
DimitrisJim:issue30335

Conversation

DimitrisJim commented May 10, 2017

Copy link
Copy Markdown
Contributor

Adds assertNotRegexpMatches to the table of deprecated aliases and fixes some of the directives that failed to mention it.

marco-buttu commented May 10, 2017

Copy link
Copy Markdown
Contributor

@DimitrisJim I made a comment on bpo-30335. I think assertNotRegexpMatches has never been introduced.

DimitrisJim commented May 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks, Marco! Yes, it looks like it was never introduced, you're not seeing it in 3.1 or 3.2 because it seems like it was forgotten; see how assertNotRegexpMatches was only renamed, it didn't get redefined as:

assertNotRegexpMatches = _deprecate(assertNotRegex)

Then, It was added again at some point in 3.5.

When the name was added again in 3.5, the deprecation alias table wasn't updated, this the main reason for this PR. My only concern is with the change I made in the versionadded:: 3.1 directive. Judging from bpo10273 I thought it existed in 3.1 (this might need changing, though, I'm not sure how this should be handled)

brettcannon added the docs Documentation in the Doc dir label May 10, 2017

brettcannon commented May 10, 2017

Copy link
Copy Markdown
Member

@DimitrisJim I'm not seeing any change about versionadded; am I overlooking something?

DimitrisJim commented May 10, 2017

Copy link
Copy Markdown
Contributor Author

The diff for rst's is really bad on GitHub's review. I changed the versionadded by adding assertNotRegexpMatches too:

       .. versionadded:: 3.1
-         under the name ``assertRegexpMatches``.
+         under the names ``assertRegexpMatches`` and ``assertNotRegexpMatches``.

marco-buttu commented May 11, 2017

Copy link
Copy Markdown
Contributor

So, as far I can see, it has been introduced (and deprecated at the same time), in Python 3.5 :/

brettcannon commented May 11, 2017

Copy link
Copy Markdown
Member

It sounds like it came in under Python 3.5 (or was at least re-added). We should do the most accurate versionadded and state it for 3.5 (even if it was in 3.1, taken out later, and then put back into 3.5 for backwards-compatibility with 2.7).

DimitrisJim commented May 12, 2017

Copy link
Copy Markdown
Contributor Author

To make reviewing a bit easier, I reverted all changes except for the new table entry in deprecated aliases.

Under assertRegex and assertNotRegex I added an additional versionadded:

+      .. versionadded:: 3.5
+         The name ``assertNotRegexpMatches`` as a deprecated alias
+         for :meth:`.assertNotRegex`.

While, under the table for the deprecated aliases, I also added a deprecated directive:

+   .. deprecated:: 3.5
+         the ``assertNotRegexpMatches`` name in favor of :meth:`.assertNotRegex`.

marco-buttu reviewed May 12, 2017
View reviewed changes
Comment thread Doc/library/unittest.rst
:meth:`.assertAlmostEqual` failUnlessAlmostEqual assertAlmostEquals
:meth:`.assertNotAlmostEqual` failIfAlmostEqual assertNotAlmostEquals
:meth:`.assertRegex` assertRegexpMatches
:meth:`.assertNotRegex` assertNotRegexpMatches

marco-buttu May 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The assertNotRegexpMatches is not available for Python < 3.5, and we are saying that it has been deprecated in Python 3.2, when it was not available. IMHO we should not include this reference.

DimitrisJim May 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, I changed that, after Brett's suggestion, to state it was introduced and deprecated at 3.5. It has to have an entry in this table so people who are porting testing code from 2 to 3 can see the new name for it.

brettcannon requested changes May 12, 2017
View reviewed changes
Comment thread Doc/library/unittest.rst Outdated
.. versionadded:: 3.2
:meth:`.assertNotRegex`.
.. versionadded:: 3.5
The name ``assertNotRegexpMatches`` as a deprecated alias

brettcannon May 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"as a" -> "is a"

brettcannon commented May 13, 2017

Copy link
Copy Markdown
Member

Everything looks good now. It simply needs to be merged and backported.

Mariatta merged commit 74921ed into python:master Jun 9, 2017

Mariatta commented Jun 9, 2017

Copy link
Copy Markdown
Member

Thanks for the PR @DimitrisJim 🎉

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
[3.6] bpo-30335: Add deprecation alias entry for assertNotRegexpMatch…
6e08b6f 
…es (pythonGH-1536)

Document that assertNotRegexpMatches is a deprecated alias for assertNotRegex.
(cherry picked from commit 74921ed)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
[3.5] bpo-30335: Add deprecation alias entry for assertNotRegexpMatch…
1b86153 
…es (pythonGH-1536)

Document that assertNotRegexpMatches is a deprecated alias for assertNotRegex.
(cherry picked from commit 74921ed)
This was referenced Jun 10, 2017
Merged
Merged
Mariatta added a commit that referenced this pull request Jun 10, 2017
[3.6] bpo-30335: Add deprecation alias entry for assertNotRegexpMatch…
10c9a09 
…es (GH-1536) (GH-2055)

Document that assertNotRegexpMatches is a deprecated alias for assertNotRegex.
(cherry picked from commit 74921ed)
Mariatta added a commit that referenced this pull request Jun 10, 2017
[3.5] bpo-30335: Add deprecation alias entry for assertNotRegexpMatch…
cabdba2 
…es (GH-1536) (GH-2056)

Document that assertNotRegexpMatches is a deprecated alias for assertNotRegex.
(cherry picked from commit 74921ed)
jvanasco mentioned this pull request Apr 25, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
Mariatta Mariatta approved these changes
+1 more reviewer
marco-buttu marco-buttu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL