Repository navigation
gh-151949: Fix Sphinx reference warnings in Doc/library/lzma.rst - #153878
Merged
zware merged 6 commits intoJul 19, 2026
Merged
zware merged 6 commits into
zware merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The lzma module constants (FORMAT_*, CHECK_*, PRESET_*, FILTER_*, MODE_* and MF_*) were referenced with the :const: role throughout the module documentation but were never defined as reference targets, producing "reference target not found" warnings under nitpicky mode. Document these public constants with .. data:: directives, following the convention used by the signal, socket and ssl modules, so the existing references resolve. The now-redundant inline descriptions of the format and check constants are condensed into linked references.
Copy link
Copy Markdown
Documentation build overview28 files changed · ± 28 modified ± Modified |
Sorry, something went wrong.
fedonman
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
July 19, 2026 10:22
Copy link
Copy Markdown
Contributor
Author
|
@zware part of EuroPython sprint. |
Sorry, something went wrong.
zware
approved these changes
Jul 19, 2026
zware
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks great, thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-154125 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-154126 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-154127 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
This was referenced Jul 22, 2026
Copy link
Copy Markdown
|
GH-154483 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-154484 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-154485 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
tomasr8
pushed a commit
that referenced
this pull request
Jul 23, 2026
…rst` (GH-153878) (#154126) * gh-151949: Fix Sphinx reference warnings in `Doc/library/lzma.rst` (GH-153878) The lzma module constants (FORMAT_*, CHECK_*, PRESET_*, FILTER_*, MODE_* and MF_*) were referenced with the :const: role throughout the module documentation but were never defined as reference targets, producing "reference target not found" warnings under nitpicky mode. Document these public constants with .. data:: directives, following the convention used by the signal, socket and ssl modules, so the existing references resolve. The now-redundant inline descriptions of the format and check constants are condensed into linked references. (cherry picked from commit 1530b38) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> * Fix nitpicks --------- Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
tomasr8
pushed a commit
that referenced
this pull request
Jul 23, 2026
…rst` (GH-153878) (#154125) * gh-151949: Fix Sphinx reference warnings in `Doc/library/lzma.rst` (GH-153878) The lzma module constants (FORMAT_*, CHECK_*, PRESET_*, FILTER_*, MODE_* and MF_*) were referenced with the :const: role throughout the module documentation but were never defined as reference targets, producing "reference target not found" warnings under nitpicky mode. Document these public constants with .. data:: directives, following the convention used by the signal, socket and ssl modules, so the existing references resolve. The now-redundant inline descriptions of the format and check constants are condensed into linked references. (cherry picked from commit 1530b38) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> * Fix nitpicks --------- Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
tomasr8
pushed a commit
that referenced
this pull request
Jul 23, 2026
…rst` (GH-153878) (#154127) * gh-151949: Fix Sphinx reference warnings in `Doc/library/lzma.rst` (GH-153878) The lzma module constants (FORMAT_*, CHECK_*, PRESET_*, FILTER_*, MODE_* and MF_*) were referenced with the :const: role throughout the module documentation but were never defined as reference targets, producing "reference target not found" warnings under nitpicky mode. Document these public constants with .. data:: directives, following the convention used by the signal, socket and ssl modules, so the existing references resolve. The now-redundant inline descriptions of the format and check constants are condensed into linked references. (cherry picked from commit 1530b38) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> * Fix nitpicks --------- Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lzma module constants (FORMAT_*, CHECK_*, PRESET_*, the FILTER_* names, MODE_* and MF_*) were referenced with the :const: role all over Doc/library/lzma.rst, but none of them were actually defined as reference targets. In nitpicky mode this produced 35 "py:const reference target not found" warnings (the full list is in the issue).
This documents those constants with .. data:: directives, the same way signal, socket and ssl already do it, so the existing :const: references resolve to real linked entries. The inline descriptions of the format and check constants in LZMACompressor become short linked references, and their full descriptions now live in the new Constants section. The BCJ filter references that are deliberately suppressed (like FILTER_X86) are left alone, since they don't emit warnings.
I checked with a nitpicky docs build (sphinx-build -n -D nitpicky=1): all 35 warnings from lzma.rst are gone and no new ones appear.
Sub-issue of #151940.