FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118150: warn in doc about results asymmetry for difflib junk by Lenormju · Pull Request #153892 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-118150: warn in doc about results asymmetry for difflib junk - #153892

Merged
encukou merged 4 commits into
python:mainfrom
Lenormju:gh-118150-difflib-autojunk-asymmetry-doc
Jul 24, 2026
ConversationCommits (4)ChecksFiles changed
Merged

gh-118150: warn in doc about results asymmetry for difflib junk#153892
encukou merged 4 commits into
python:mainfrom
Lenormju:gh-118150-difflib-autojunk-asymmetry-doc

Conversation

Lenormju commented Jul 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

python-cla-bot Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added the docs Documentation in the Doc dir label Jul 18, 2026
github-project-automation Bot moved this to Todo in Docs PRs Jul 18, 2026
bedevere-app Bot mentioned this pull request Jul 18, 2026
Closed

read-the-docs-community Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33647276 | 📁 Comparing 0793740 against main (cffcee4)

  🔍 Preview build  

16 files changed · ± 16 modified

± Modified

encukou added the sprint label Jul 18, 2026
github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
encukou self-assigned this Jul 18, 2026
encukou reviewed Jul 18, 2026
View reviewed changes
Comment thread Doc/library/difflib.rst Outdated
Comment thread Doc/library/difflib.rst Outdated
Comment thread Doc/library/difflib.rst Outdated
This was referenced Jul 18, 2026
Closed
Merged
encukou reviewed Jul 19, 2026
View reviewed changes
Comment thread Doc/library/difflib.rst
Comment on lines 22 to 25
.. class:: SequenceMatcher
:noindex:

This is a flexible class for comparing pairs of sequences of any type, so long

encukou Jul 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What do you think about making this an introduction to the difflib module, rather than docs for the SequenceMatcher class (which is documented properly below)?

Something like this, plus dedenting it:

All functionality in this module uses the algorithm implemented in
:class:`SequenceMatcher`, a flexible class for comparing pairs
of sequences of any type, so long […]

Lenormju Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree, because in the end everything relies on it. But can we do that in another PR, iteratively ?

encukou Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK. I'll send the PR.

encukou Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sent: #154662

encukou added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 24, 2026
encukou merged commit 59e67c2 into python:main Jul 24, 2026
36 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 24, 2026
github-project-automation Bot moved this from Todo to Done in Sprint Jul 24, 2026

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @Lenormju for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154658 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 24, 2026

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154659 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 24, 2026

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154660 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 24, 2026
encukou pushed a commit that referenced this pull request Jul 24, 2026
[3.15] gh-118150: warn in doc about results asymmetry for difflib junk (
1f53f91 
GH-153892) (GH-154658)

(cherry picked from commit 59e67c2)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
encukou pushed a commit that referenced this pull request Jul 24, 2026
[3.14] gh-118150: warn in doc about results asymmetry for difflib junk (
a73668a 
GH-153892) (GH-154659)

(cherry picked from commit 59e67c2)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
encukou pushed a commit that referenced this pull request Jul 24, 2026
[3.13] gh-118150: warn in doc about results asymmetry for difflib junk (
970a738 
GH-153892) (GH-154660)

(cherry picked from commit 59e67c2)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
Lenormju deleted the gh-118150-difflib-autojunk-asymmetry-doc branch August 11, 2026 11:04
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-118150: warn in doc about results asymmetry for difflib junk (…
d0efede 
…pythonGH-153892)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments

Assignees

encukou

Labels

docs Documentation in the Doc dir sprint

Projects

Docs PRs
Status: Done
Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL