Repository navigation
gh-153395: Fix test_complexchar on narrow curses builds - #154005
Merged
serhiy-storchaka merged 1 commit intoJul 18, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
On a narrow build, complexchar() of a multibyte character raises OverflowError, not ValueError. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
zware
approved these changes
Jul 18, 2026
Copy link
Copy Markdown
Member
Author
|
It was reported in #153396 (comment). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_complexchar errors on narrow curses builds under a multibyte (e.g. UTF-8) locale: complexchar('\xe9') raises OverflowError (the character has no single-byte cell) rather than ValueError, which the storable() helper did not catch, so the non-ASCII assertions raised instead of being skipped.
This surfaced as buildbot failures on Debian root and macOS after gh-153395; the OverflowError itself is long-standing behaviour of PyCurses_ConvertToChtype, not new.