Repository navigation
gh-153903: Use @ctypes.util.wrap_dll_function() with pythonapi - #154030
Merged
vstinner merged 5 commits intoJul 19, 2026
Merged
vstinner merged 5 commits into
vstinner merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use the @ctypes.util.wrap_dll_function() decorator with ctypes.pythonapi to wrap Python C API functions in the test suite.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The readability improvement is really nice
Sorry, something went wrong.
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Copy link
Copy Markdown
Member
Author
Readability is nice, but my first motivation is correctness. The new syntax reduces the risk of typo when declaring a ctypes function. |
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
July 19, 2026 10:14
Copy link
Copy Markdown
Member
Author
Ah, test_logging failed. I just re-ran the job. FAIL: test_rollover_at_midnight (test.test_logging.TimedRotatingFileHandlerTest.test_rollover_at_midnight)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_logging.py", line 6749, in test_rollover_at_midnight
self.assertIn(f'testing2 {i}', line)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'testing2 0' not found in '2026-07-19 11:25:12,102 testing1 0\n'
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the @ctypes.util.wrap_dll_function() decorator with ctypes.pythonapi to wrap Python C API functions in the test suite.