Repository navigation
gh-153903: Fix ctypes wrap_dll_function() with string annotations - #154042
Merged
vstinner merged 1 commit intoJul 19, 2026
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Call get_annotations() with eval_str=True.
Copy link
Copy Markdown
Member
Author
|
@ctypes.util.struct has the same bug: see PR gh-154040 which fixes it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
With this change, the following example: import ctypes.util
@ctypes.util.wrap_dll_function(ctypes.pythonapi)
def Py_GetVersion() -> 'invalid return type':
...now fails with SyntaxError: Traceback (most recent call last):
File "/home/vstinner/python/main/ann.py", line 3, in <module>
@ctypes.util.wrap_dll_function(ctypes.pythonapi)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/home/vstinner/python/main/Lib/ctypes/util.py", line 582, in decorator
annotations = annotationlib.get_annotations(func, eval_str=True)
File "/home/vstinner/python/main/Lib/annotationlib.py", line 1078, in get_annotations
else eval(_rewrite_star_unpack(value), globals, locals)
~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<string>", line 1
invalid return type
^^^^^^
SyntaxError: invalid syntax
Hopefully, the traceback starts at line 3 of ann.py which is the line creating Py_GetVersion(), so the traceback is correct and helpful! |
Sorry, something went wrong.
ZeroIntensity
approved these changes
Jul 19, 2026
Copy link
Copy Markdown
Member
Author
|
Merged, thanks for the review. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call get_annotations() with eval_str=True.