gh-154060: Preserve replay duration and rate by pablogsal · Pull Request #154101 · python/cpython · GitHub

Issue: Tachyon flamegraph: Replaying binary file doesn’t show time/rate in sidebar #154060

I believe this comment #154105 (review) is applicable here as well.

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Sorry, @pablogsal, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480 3.15

GH-156407 is a backport of this pull request to the 3.15 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Alpine Linux NoGIL 3.x (tierless) has failed when building commit 7f0ccd6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1819/builds/2922) and take a look at the build logs.
Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1819/builds/2922

Summary of the results of the build (if available):

==

Click to see traceback logs

Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

configure: WARNING: x86_64-pc-linux-musl/gcc is not supported
configure: WARNING:

Platform "x86_64-pc-linux-musl" with compiler "gcc" is not supported by the
CPython core team, see https://peps.python.org/pep-0011/ for more information.


make: *** [Makefile:2476: buildbottest] Error 3

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit 7f0ccd6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/3257) and take a look at the build logs.
Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/3257

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f85 gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3451: clean-retain-profile] Error 1 (ignored)
./Modules/socketmodule.c: In function ‘getsockaddrarg’:
./Modules/socketmodule.c:2664:9: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
 2664 |         strncpy((char *)sa->salg_name, name, sizeof(sa->salg_name));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make[2]: *** [Makefile:1164: libpython3.16.a] Error 1
make[1]: *** [Makefile:997: profile-gen-stamp] Error 2
make: *** [Makefile:1009: profile-run-stamp] Error 2

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.x (tier-3) has failed when building commit 7f0ccd6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1654/builds/3221) and take a look at the build logs.
Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1654/builds/3221

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f8 gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make: *** [Makefile:1164: libpython3.16.a] Error 1

)

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable 3.15 (tier-3) has failed when building commit 27c8f1f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2016/builds/357) and take a look at the build logs.
Check if the failure is related to this commit (27c8f1f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2016/builds/357

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '27c8f1fd152cdd4ab84ed5e426247e5531d9e614'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 27c8f1fd152cd [3.15] gh-154060: Preserve replay duration and rate (GH-154101) (#156407)
Switched to and reset branch '3.15'

ar: unable to copy file 'libpython3.15d.a'; reason: No space left on device
make: *** [Makefile:1199: libpython3.15d.a] Error 1

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang 3.15 (tier-3) has failed when building commit 27c8f1f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2119/builds/332) and take a look at the build logs.
Check if the failure is related to this commit (27c8f1f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2119/builds/332

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '27c8f1fd152cdd4ab84ed5e426247e5531d9e614'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 27c8f1fd152 [3.15] gh-154060: Preserve replay duration and rate (GH-154101) (#156407)
Switched to and reset branch '3.15'

configure: WARNING: s390x-ibm-linux-gnu/clang is not supported
configure: WARNING:

Platform "s390x-ibm-linux-gnu" with compiler "clang" is not supported by the
CPython core team, see https://peps.python.org/pep-0011/ for more information.


Objects/unicodeobject.c:4902:1: warning: unused function 'ctz' [-Wunused-function]
 4902 | ctz(size_t v)
      | ^~~
1 warning generated.
ar: libpython3.15d.a: error reading Python/ceval_gil.o: No space left on device
make: *** [Makefile:1199: libpython3.15d.a] Error 1
make: *** Waiting for unfinished jobs....

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang Installed 3.15 (tier-3) has failed when building commit 27c8f1f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2046/builds/322) and take a look at the build logs.
Check if the failure is related to this commit (27c8f1f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2046/builds/322

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '27c8f1fd152cdd4ab84ed5e426247e5531d9e614'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 27c8f1fd152cd [3.15] gh-154060: Preserve replay duration and rate (GH-154101) (#156407)
Switched to and reset branch '3.15'

configure: WARNING: s390x-ibm-linux-gnu/clang is not supported
configure: WARNING:

Platform "s390x-ibm-linux-gnu" with compiler "clang" is not supported by the
CPython core team, see https://peps.python.org/pep-0011/ for more information.


In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:285:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  285 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:292:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  292 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:438:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  438 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:445:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  445 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:551:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  551 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:560:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  560 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:582:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  582 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:593:9: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  593 |         CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |         ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:690:11: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  690 |           CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |           ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:735:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  735 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:761:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  761 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:772:9: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  772 |         CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |         ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:785:11: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  785 |           CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |           ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:930:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  930 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:943:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  943 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:960:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  960 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:118:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  118 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:967:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  967 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:1202:7: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
 1202 |       CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |       ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
In file included from ./Modules/expat/xmltok.c:312:
./Modules/expat/xmltok_impl.c:1222:11: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
 1222 |           CHECK_NAME_CASES(enc, ptr, end, nextTokPtr)
      |           ^
./Modules/expat/xmltok_impl.c:89:5: note: expanded from macro 'CHECK_NAME_CASES'
   89 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:47:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   47 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
19 warnings generated.
Objects/unicodeobject.c:4902:1: warning: unused function 'ctz' [-Wunused-function]
 4902 | ctz(size_t v)
      | ^~~
rror: unable to open output file 'Python/getopt.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/getopt.o] Error 1
make: *** Waiting for unfinished jobs....
rror: unable to open output file 'Python/pystrcmp.o': 'No space left on device'
1 error generated.
rror: unable to open output file 'Python/pystate.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/pystrcmp.o] Error 1
make: *** [Makefile:3430: Python/pystate.o] Error 1
rror: unable to open output file 'Python/uniqueid.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/uniqueid.o] Error 1
rror: unable to open output file 'Python/traceback.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/traceback.o] Error 1
rror: unable to open output file 'Python/tracemalloc.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/tracemalloc.o] Error 1
rror: unable to open output file 'Python/sysmodule.o': 'No space left on device'
1 error generated.
make: *** [Makefile:2195: Python/sysmodule.o] Error 1
rror: unable to open output file 'Python/symtable.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3430: Python/symtable.o] Error 1
rror: unable to open output file 'Python/ceval.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3440: Python/ceval.o] Error 1
rror: unable to open output file 'Objects/unicodeobject.o': 'No space left on device'
1 warning and 1 error generated.
make: *** [Makefile:3430: Objects/unicodeobject.o] Error 1

chmod: cannot access 'target/': No such file or directory

bedevere-app Bot mentioned this pull request Jul 19, 2026

Tachyon flamegraph: Replaying binary file doesn’t show time/rate in sidebar #154060

Closed

pablogsal changed the title gh-154060: Show replay duration and rate gh-154060: Preserve replay duration and rate Jul 19, 2026

pablogsal added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 19, 2026

pablogsal requested a review from ivonastojanovic July 19, 2026 13:58

pablogsal force-pushed the agent/gh-154060-replay-duration-rate branch from 5490417 to 8b117f6 Compare July 19, 2026 14:22

pablogsal marked this pull request as ready for review July 19, 2026 14:28

pablogsal requested a review from AA-Turner as a code owner July 19, 2026 14:28

bedevere-app Bot added the awaiting core review label Jul 19, 2026

maurycy mentioned this pull request Jul 23, 2026

Add Perfetto trace output to profiling.sampling #150327

Open

pablogsal added 4 commits August 26, 2026 00:53

pythongh-154060 : Show replay duration and rate

05b63cf

pythongh-154060 : Preserve replay mode when available

3372743

pythongh-154060 : Persist measured replay statistics

a42debf

pythongh-154060 : Preserve existing replay metadata

f637be1

pablogsal force-pushed the agent/gh-154060-replay-duration-rate branch from 8b117f6 to f637be1 Compare August 25, 2026 23:53

pablogsal added 2 commits August 26, 2026 01:17

pythongh-154060 : Preserve replay failure statistics

42019d8

pythongh-154060 : Regenerate global identifiers

a678131

pablogsal merged commit 7f0ccd6 into python:main Aug 26, 2026
54 checks passed

pablogsal deleted the agent/gh-154060-replay-duration-rate branch August 26, 2026 09:24

bedevere-app Bot removed the awaiting core review label Aug 26, 2026

miss-islington-app Bot assigned pablogsal Aug 26, 2026

pablogsal mentioned this pull request Aug 26, 2026

[3.15] gh-154060: Preserve replay duration and rate (GH-154101) #156407

Merged

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 26, 2026

pablogsal added a commit that referenced this pull request Aug 26, 2026

[3.15] gh-154060 : Preserve replay duration and rate (GH-154101 ) (#156407

27c8f1f

)

gh-154060: Preserve replay duration and rate by pablogsal · Pull Request #154101 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-154060: Preserve replay duration and rate - #154101

gh-154060: Preserve replay duration and rate#154101
pablogsal merged 6 commits into
python:mainfrom
pablogsal:agent/gh-154060-replay-duration-rate

pablogsal commented Jul 19, 2026 •
edited
Loading

Uh oh!

Uh oh!

pablogsal commented Jul 19, 2026

Uh oh!

maurycy commented Jul 20, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Aug 26, 2026

Uh oh!

miss-islington-app Bot commented Aug 26, 2026

Uh oh!

bedevere-app Bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-154060: Preserve replay duration and rate by pablogsal · Pull Request #154101 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-154060: Preserve replay duration and rate - #154101

gh-154060: Preserve replay duration and rate#154101pablogsal merged 6 commits intopython:mainpython/cpython:mainfrom pablogsal:agent/gh-154060-replay-duration-ratepablogsal/cpython:agent/gh-154060-replay-duration-rateCopy head branch name to clipboard

Conversation

pablogsal commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pablogsal commented Jul 19, 2026

Uh oh!

maurycy commented Jul 20, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Aug 26, 2026

Uh oh!

miss-islington-app Bot commented Aug 26, 2026

Uh oh!

bedevere-app Bot commented Aug 26, 2026

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 26, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-154060: Preserve replay duration and rate#154101
pablogsal merged 6 commits into
python:mainfrom
pablogsal:agent/gh-154060-replay-duration-rate

pablogsal commented Jul 19, 2026 •
edited
Loading