Repository navigation
gh-145559: Make PyUnstable_DumpTraceback return void again - #154131
Closed
hoodmane wants to merge 1 commit into
Closed
hoodmane wants to merge 1 commit into
hoodmane wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In pythongh-148145, we changed this to return a const char* but it is always NULL. I don't think this makes sense, so this puts it back.
Copy link
Copy Markdown
Member
|
const char* return type is a deliberate choice. See for example: |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Makes sense, thanks! (I asked @encukou in person and he didn't remember the discussion about this.) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gh-148145, we changed this to return a const char* but it is always NULL. I don't think this makes sense, so this puts it back.