Repository navigation
[3.14] gh-153862: Fix curses window.inch() for non-ASCII characters on a wide build (GH-153863) - #154151
Merged
serhiy-storchaka merged 1 commit intoJul 19, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ters on a wide build (pythonGH-153863) On a wide build, winch() returns the low 8 bits of the character's code point with no locale conversion, so inch()/mvinch() disagreed with instr() for a non-ASCII character of an 8-bit locale ('€' under ISO-8859-15 gave 0xAC instead of 0xA4). Re-encode the cell to its locale byte via wctob(), as ncurses does for getbkgd(). (cherry picked from commit a83aaa9) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
Documentation build overview415 files changed · + 1 added · ± 394 modified · - 20 deleted + Added ± Modified
- Deleted
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #153863; the automatic backport hit a conflict.
3.14 predates both the 3.16 complexchar refactor and the 3.15 error-handling refactor, so inch() keeps its unsigned long return and just gains the wide-cell locale-byte recovery (the getcchar() + wctob() helper).
Verified on a wide (HAVE_NCURSESW) build: test_read_from_window passes under ISO-8859-15 where € (0xA4) exercises the fix, and the full test_curses is green there once the paired insch fix (gh-153864) is also applied.