Repository navigation
gh-82535: Ignore address resolution failure in SysLogHandler constructor - #154504
Merged
serhiy-storchaka merged 1 commit intoAug 10, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…nstructor The address may be temporarily unresolvable when the handler is created. It is resolved again when a record is emitted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vsajip
approved these changes
Aug 10, 2026
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-155457 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-155458 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-155459 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…nstructor (pythonGH-154504) The address may be temporarily unresolvable when the handler is created. It is resolved again when a record is emitted. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 29, 2026
…onstructor (GH-154504) (#155459) gh-82535: Ignore address resolution failure in SysLogHandler constructor (GH-154504) The address may be temporarily unresolvable when the handler is created. It is resolved again when a record is emitted. (cherry picked from commit c294654) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 10, 2026
…onstructor (GH-154504) (GH-155457) The address may be temporarily unresolvable when the handler is created. It is resolved again when a record is emitted. (cherry picked from commit c294654) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 10, 2026
…onstructor (GH-154504) (GH-155458) The address may be temporarily unresolvable when the handler is created. It is resolved again when a record is emitted. (cherry picked from commit c294654) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SysLogHandler resolves the address in the constructor, so creating a handler fails if the address is temporarily unresolvable, for example if DNS is not available yet.
Only the resolution failure is ignored, and the address is resolved again when a record is emitted. TimeoutError and ConnectionRefusedError are still raised from the constructor, so the behaviour added in gh-126400 is not affected.
🤖 Generated with Claude Code