FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154189: Fix use-after-free in `functools.partial_vectorcall` by brijkapadia · Pull Request #154508 · python/cpython · GitHub

/ cpython Public

gh-154189: Fix use-after-free in functools.partial_vectorcall - #154508

Merged
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall
Jul 24, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-154189: Fix use-after-free in functools.partial_vectorcall#154508
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall

Conversation

brijkapadia commented Jul 22, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

brijkapadia requested a review from rhettinger as a code owner July 22, 2026 19:59
bedevere-app Bot mentioned this pull request Jul 22, 2026
Closed

brijkapadia commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@encukou, could you review this whenever you have time?
I'm asking since you reviewed #145362, which is similar to this pr.

encukou approved these changes Jul 24, 2026
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! This checks out. Are you up for a bit of additional cleanup?

Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated
encukou approved these changes Jul 24, 2026
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

encukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 24, 2026
encukou merged commit 1a742d4 into python:main Jul 24, 2026
62 of 63 checks passed

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @brijkapadia for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Sorry, @brijkapadia and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a742d403243ac9915ffcc54e29516e58c44dc42 3.14

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154652 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 24, 2026
brijkapadia deleted the partial-vectorcall branch July 24, 2026 21:42

brijkapadia commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

I don't think PR needs to be backported to 3.14.

encukou pushed a commit that referenced this pull request Jul 27, 2026
[3.15] gh-154189: Fix use-after-free in functools.partial_vectorcall (
6246342 
GH-154508) (#154652)

(cherry picked from commit 1a742d4)

Co-authored-by: Brij Kapadia <97006829+brijkapadia@users.noreply.github.com>

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member

I agree; it doesn't look worth the effort.

encukou removed the needs backport to 3.14 bugs and security fixes label Jul 27, 2026
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-154189: Fix use-after-free in functools.partial_vectorcall (…
231b8c6 
…pythonGH-154508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL