Repository navigation
gh-138252: Document OpenSSL version requirements for the ssl signature-algorithm APIs - #154521
Closed
fedonman wants to merge 1 commit into
Closed
fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…gnature-algorithm APIs
Copy link
Copy Markdown
Documentation build overview1 file changed ± library/ssl.html |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Please incoporate these changes in 154517 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small documentation follow-up to the signature-algorithm support added in gh-138252.
Three of those APIs require a specific OpenSSL version, but the reference docs don't mention it. ssl.get_sigalgs() requires OpenSSL 3.4 or later, and SSLSocket.client_sigalg() and SSLSocket.server_sigalg() require 3.5 or later. On an older version each raises NotImplementedError. The requirement is already stated in the What's New in 3.15 entry and enforced in the C code (Modules/_ssl.c), so this just brings the three reference entries in line.
A companion PR, #154518, adds the same kind of note to SSLSocket.group() and SSLContext.get_groups().
This is documentation only, so there is no news entry.