FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154525: Fix curses getcchar() failure on ncurses older than 6.3 by serhiy-storchaka · Pull Request #154526 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-154525: Fix curses getcchar() failure on ncurses older than 6.3 #154526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Jul 23, 2026
Conversation 0 Commits 2 Checks 54 Files changed
Merged

gh-154525: Fix curses getcchar() failure on ncurses older than 6.3 #154526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cad3106
gh-154525: Fix curses getcchar() failure on ncurses older than 6.3
serhiy-storchaka Jul 23, 2026
9de6a48
Inline the single-use getcchar() extended-pair condition
serhiy-storchaka Jul 23, 2026
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 3 additions & 1 deletion Modules/_cursesmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,9 @@ curses_getcchar(const cchar_t *wcval, wchar_t *wstr, attr_t *attrs, int *pair)
/* getcchar() is not guaranteed to write the text of an empty cell, so make
the output an empty string by default. */
wstr[0] = L'\0';
#if _NCURSES_EXTENDED_COLOR_FUNCS
/* getcchar()'s opts slot returns the extended color pair, but ncurses
returned ERR for a non-NULL opts until 6.3 (patch 20210116). */
#if _NCURSES_EXTENDED_COLOR_FUNCS && NCURSES_VERSION_PATCH+0 >= 20210116
int rtn = getcchar(wcval, wstr, attrs, &spair, pair);
#else
int rtn = getcchar(wcval, wstr, attrs, &spair, NULL);
Expand Down
Loading
Back | FazBrowse Home | New Git URL