| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -657,15 +657,20 @@ def send(self, s): | |
| This function allows for partial sends which can happen when the | ||
| network is busy. | ||
| """ | ||
| if self.sock is None: | ||
| self.createSocket() | ||
| #self.sock can be None either because we haven't reached the retry | ||
| #time yet, or because we have reached the retry time and retried, | ||
| #but are still unable to connect. | ||
| if self.sock: | ||
| # Reopen the socket once if sending fails, e.g. the connection was | ||
| # closed after a timeout, so the record is not lost (gh-84532). | ||
| for attempt in range(2): | ||
| if self.sock is None: | ||
| self.createSocket() | ||
| # self.sock can be None either because we haven't reached the | ||
| # retry time yet, or because we have reached the retry time | ||
| # and retried, but are still unable to connect. | ||
| if self.sock is None: | ||
| return | ||
| try: | ||
| self.sock.sendall(s) | ||
| except OSError: #pragma: no cover | ||
| return | ||
|
Comment thread
Copy link
Copy Markdown
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityAs comment above.
Sorry, something went wrong.
All reactions
|
||
| except OSError: | ||
| self.sock.close() | ||
| self.sock = None # so we can call createSocket next time | ||
|
|
||
| Expand Down | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| :class:`logging.handlers.SocketHandler` now loses fewer log records when the | ||
| connection to the server is closed, for example after an idle timeout. |
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityHow about a break here? I prefer not to do early returns - e.g. if we were ever to add something after the for statement, we wouldn't need to revisit this line.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.