FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154199: Soft-deprecate `ctypes.util.find_msvcrt` by ZeroIntensity · Pull Request #154553 · python/cpython · GitHub

Repository navigation

gh-154199: Soft-deprecate ctypes.util.find_msvcrt - #154553

Merged
ZeroIntensity merged 3 commits into
python:mainfrom
ZeroIntensity:ctypes/no-more-find-msvcrt
Jul 25, 2026
Merged

ZeroIntensity merged 3 commits into
python:mainfrom
ZeroIntensity:ctypes/no-more-find-msvcrt

Conversation

ZeroIntensity commented Jul 23, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

read-the-docs-community Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33732836 | 📁 Comparing b04411d against main (2b4e062)

  🔍 Preview build  

2 files changed
± library/ctypes.html
± whatsnew/changelog.html

Comment thread Lib/ctypes/util.py
if '_d.pyd' in importlib.machinery.EXTENSION_SUFFIXES:
clibname += 'd'
return clibname+'.dll'
"""Return the name of the VC runtime dll.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This renders _get_build_version unused. Can it be removed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ZeroIntensity, as you'll be doing this more often: consider doing deprecation periods for underscored API as well, if there's no harm in keeping things around for a few more years.
Most of the module predates clear docs on what the underscore means, so existing code might use such functions.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, right, thanks for the reminder. I think this one is okay because I couldn't find any uses of it after a quick code search.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, this is more of a general reminder of what to keep in mind.
As for code searches, be careful -- this stuff also predates GitHub's hegemony.

Copy link
Copy Markdown
Member

This supersedes #154209 which can now be closed?

ZeroIntensity merged commit ada9da9 into python:main Jul 25, 2026
95 of 97 checks passed
ZeroIntensity deleted the ctypes/no-more-find-msvcrt branch July 25, 2026 14:08
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL