FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154431: Revert "gh-154431: Fix data race in `sys.audithook` (#154462)" by encukou · Pull Request #154769 · python/cpython · GitHub

/ cpython Public

gh-154431: Revert "gh-154431: Fix data race in sys.audithook (#154462)" - #154769

Merged
encukou merged 1 commit into
python:mainfrom
encukou:revert-596cd5c
Jul 27, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-154431: Revert "gh-154431: Fix data race in sys.audithook (#154462)"#154769
encukou merged 1 commit into
python:mainfrom
encukou:revert-596cd5c

Conversation

encukou commented Jul 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit 596cd5c.

This commit caused a refleak, breaking a tier 1 buildbot.

Revert "pythongh-154431: Fix data race in sys.audithook (python#154462
c96bdde 
)"

This commit caused a refleak.

This reverts commit 596cd5c.
bedevere-app Bot mentioned this pull request Jul 27, 2026
Open

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

The reverted commit caused a refleak, breaking a tier 1 buildbot; see e.g. https://buildbot.python.org/#/builders/1610/builds/3726

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

!buildbot CentOS9.NoGIL.Refleaks

bedevere-bot commented Jul 27, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit c96bdde 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F154769%2Fmerge

The command will test the builders whose names match following regular expression: CentOS9.NoGIL.Refleaks

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR

hugovk approved these changes Jul 27, 2026
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Passed ✅ https://buildbot.python.org/all/#/builders/1606/builds/935

encukou merged commit c7b9a13 into python:main Jul 27, 2026
103 of 105 checks passed
encukou deleted the revert-596cd5c branch July 27, 2026 14:00
encukou added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 27, 2026

miss-islington-app Bot commented Jul 27, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jul 27, 2026

Copy link
Copy Markdown

GH-154774 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 27, 2026
encukou added a commit that referenced this pull request Jul 27, 2026
[3.15] gh-154431: Revert "gh-154431: Fix data race in sys.audithook (…
44fca7e 
…GH-154462)" (GH-154769) (GH-154774)

This reverts commit 596cd5c.
This commit caused a refleak.

(cherry picked from commit c7b9a13)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
0rkz mentioned this pull request Jul 28, 2026
Open
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-154431: Revert "pythongh-154431: Fix data race in `sys.audit…
a3b278f 
…hook` (python#154462)" (pythonGH-154769)

This commit caused a refleak.

This reverts commit 596cd5c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL