Repository navigation
gh-150167: Force eager import of _bz2 in bz2.py to fix supported format detection - #154771
Closed
DavidCEllis wants to merge 10 commits into
Closed
DavidCEllis wants to merge 10 commits into
DavidCEllis wants to merge 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… be removed without forcibly re-importing them.
… undocumented `usefrozen` argument and correct the signature as `deprecated` and `usefrozen` are keyword only arguments.
DavidCEllis
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
giampaolo,
ncoghlan and
warsaw
as code owners
July 27, 2026 12:50
Copy link
Copy Markdown
Documentation build overview38 files changed · ± 38 modified ± Modified |
Sorry, something went wrong.
brettcannon
removed their request for review
August 6, 2026 19:30
Copy link
Copy Markdown
Contributor
Author
|
This PR needs to be updated to test the compression modules directly rather than through shutil due to the changes in shutil that make it import the internal modules directly now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds import _bz2; _bz2 to bz2.py which has the effect of making the import eager even under the 'all' lazy imports mode.
Fixes the issue where bz2 would always be reported as supported by shutil under lazy_imports=all even if it was unavailable. This should also fix this same logic where it's reused in other places (such as test_support).
I think it may make sense to add a SUPPORTED_MODULES attribute to compression that lists which modules are available by checking the internal modules directly, but that can be done on top of this.
The 'import' change that added all of the import codeowners as reviewers:
In order to test that a fresh shutil would correctly identify 'bz2' as unavailable if _bz2 is blocked I needed to add an argument to test.support.import_helpers.import_fresh_module to allow bz2 to be cleared without requiring it successfully re-import. This is the new optional cleared argument.
This new argument is documented, along with the previously undocumented 'usefrozen' argument and the signature in the documentation now correctly identifies the 'deprecated' argument as keyword-only.