FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148286: Track JIT-allocated memory with Valgrind client requests by matthiasgoergens · Pull Request #154926 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148286: Track JIT-allocated memory with Valgrind client requests #154926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasgoergens wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 1 Checks 68 Files changed
Open

gh-148286: Track JIT-allocated memory with Valgrind client requests #154926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-18-30-00.gh-issue-148286.Qv8Rk3.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Track JIT-allocated machine-code buffers with Valgrind client requests, so
that memcheck's leak checker can see them. ``jit_alloc()`` and ``jit_free()``
use ``mmap`` and ``munmap`` directly, which Valgrind does not track as
allocations, making a forgotten free invisible. Guarded by the existing
:option:`--with-valgrind` configure option.
17 changes: 17 additions & 0 deletions Python/jit.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@
#include <sys/mman.h>
#endif

#ifdef WITH_VALGRIND
// VALGRIND_MALLOCLIKE_BLOCK and VALGRIND_FREELIKE_BLOCK live in
// valgrind.h, which is the header configure already probes for
// --with-valgrind (see also Objects/obmalloc.c).
#include <valgrind/valgrind.h>
#endif

static size_t
get_page_size(void)
{
Expand Down Expand Up @@ -139,6 +146,13 @@ jit_alloc(size_t size)
jit_error("unable to allocate memory");
return NULL;
}
#ifdef WITH_VALGRIND
// Let memcheck track this JIT code region like a heap allocation, so its
// leak checker and addressability/definedness tracking apply to it. The
// whole region is always freed in one jit_free() call (never partially),
// matching the "one MALLOCLIKE_BLOCK per FREELIKE_BLOCK" contract.
VALGRIND_MALLOCLIKE_BLOCK(memory, size, /*redzone=*/0, /*is_zeroed=*/0);
#endif
return memory;
}

Expand All @@ -147,6 +161,9 @@ jit_free(unsigned char *memory, size_t size)
{
assert(size);
assert(size % get_page_size() == 0);
#ifdef WITH_VALGRIND
VALGRIND_FREELIKE_BLOCK(memory, /*redzone=*/0);
#endif
#ifdef MS_WINDOWS
int failed = !VirtualFree(memory, 0, MEM_RELEASE);
#else
Expand Down
Loading
Back | FazBrowse Home | New Git URL