Repository navigation
gh-139314: Add support for linking against zlib-rs and libbzip2-rs - #155119
Merged
StanFromIreland merged 2 commits intoAug 14, 2026
Merged
StanFromIreland merged 2 commits into
StanFromIreland merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
StanFromIreland
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
August 3, 2026 12:39
gpshead
approved these changes
Aug 12, 2026
emmatyping
approved these changes
Aug 14, 2026
Copy link
Copy Markdown
Member
|
Exciting, thanks for working on this :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Documentation build overview3 files changed ± using/configure.html ± whatsnew/3.16.html ± whatsnew/changelog.html |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the reviews! |
Sorry, something went wrong.
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finished off what was started in #139315. I also opted to implement the more generic configure options (based on the ones we have for other libraries, like --with-curses and --with-readline) as discussed in the issue.
The tests pass when built with zlib-rs (as expected), but also result in a spurious debug message from zlib-rs ending up in stderr. I've reported this upstream in trifectatechfoundation/zlib-rs#553.