Repository navigation
gh-155194: Fix not raising on non-module import - #155189
Merged
DinoV merged 5 commits intoAug 14, 2026
Merged
DinoV merged 5 commits into
DinoV merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
DinoV
marked this pull request as ready for review
August 4, 2026 22:49
DinoV
requested review from
AA-Turner,
FFY00,
Yhg1s,
brettcannon,
emmatyping,
ericsnowcurrently,
erlend-aasland,
itamaro,
kumaraditya303,
ncoghlan,
pablogsal and
warsaw
as code owners
August 4, 2026 22:49
encukou
reviewed
Aug 10, 2026
Comment thread
Python/import.c
pablogsal
reviewed
Aug 11, 2026
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Only one small comment
Sorry, something went wrong.
Comment thread
Lib/test/test_lazy_import/__init__.py
| """) | ||
| assert_python_ok("-c", code) | ||
|
|
||
| def test_missing_attribute_raises_import_error(self): |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe I am misreading this but i think this covers a different path. lazy import math.pi as pi still resolves pi to the float instead of raising.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
pablogsal
approved these changes
Aug 14, 2026
Copy link
Copy Markdown
|
Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @DinoV, I could not cleanly backport this to 3.15 due to a conflict. cherry_picker dffac6163e693cf80ed42cdc8e2cb5c0cb9577d7 3.15 |
Sorry, something went wrong.
This was referenced Aug 18, 2026
Copy link
Copy Markdown
|
GH-155983 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
pablogsal
pushed a commit
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As initially reported here: https://discuss.python.org/t/sys-lazy-modules-clarification/108385
lazy import math.pi has divergent behavior from import math.pi. Currently we allow this to work and just give you the math module. Instead we should raise ModuleNotFoundError because math.pi is not a module.