gh-107570: Argument Clinic: report errors on the offending line - #155250
Merged
serhiy-storchaka merged 2 commits intoAug 19, 2026
Merged
gh-107570: Argument Clinic: report errors on the offending line#155250serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Errors raised while the docstring is checked were reported on the line which ends the clinic block, and errors raised while the code is generated were reported without a file name and a line number at all. Functions and parameters now record the line on which they are declared, and the function docstring records where it starts, so that such errors point at the offending line.
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 5, 2026 16:04
# Conflicts: # Tools/clinic/libclinic/parse_args.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors raised while the docstring is checked were reported on the line which ends the clinic block:
and errors raised while the code is generated were reported without a file name and a line number at all:
Error: You cannot use optional groups ('[' and ']') unless all parameters are positional-only ('/').Functions and parameters now record the line on which they are declared, and the function docstring records where it starts, so that such errors point at the offending line: the line which should have been left blank, the too long summary line, the first too long line of the docstring body, the second {parameters} marker, or the declaration of the function or the parameter.