gh-155327: Guard SSLSocket chain methods after TLS teardown - #155328
Open
tonghuaroot wants to merge 1 commit into
Open
gh-155327: Guard SSLSocket chain methods after TLS teardown#155328tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
get_verified_chain() and get_unverified_chain() accessed self._sslobj without the guard used by the other query methods, raising AttributeError after unwrap(). Return an empty list instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLSocket.get_verified_chain() and get_unverified_chain() accessed
self._sslobj without the _checkClosed() / None guard used by every other
query method, so they raised AttributeError when called after the TLS layer
was torn down (for example after unwrap()). Add the guard and return an empty
list, matching the value these methods return for an empty chain.