FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-151365: Temporarily downgrade Git to prevent fatal error by hugovk · Pull Request #155495 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-151365: Temporarily downgrade Git to prevent fatal error - #155495

Merged
hugovk merged 2 commits into
python:mainfrom
hugovk:3.16-downgrade-git
Aug 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-151365: Temporarily downgrade Git to prevent fatal error#155495
hugovk merged 2 commits into
python:mainfrom
hugovk:3.16-downgrade-git

Conversation

hugovk commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Downgrading takes 7 seconds.

Upgrading via build from source (+cache) or Homebrew are likely to take longer.

bedevere-app Bot mentioned this pull request Aug 10, 2026
Closed
hugovk marked this pull request as ready for review August 10, 2026 16:18

webknjaz commented Aug 10, 2026

Copy link
Copy Markdown
Member

Is it possible to explicitly declare the version limit in the command, plz?

vstinner approved these changes Aug 10, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

It works as expected. For example, I see "git version 2.43.0" in the "Downgrade Git" step of Docs/Docs CI job.

Comment thread .github/workflows/reusable-check-html-ids.yml Outdated
# to avoid "fatal: shallow file has changed since we read it" bug.
# See https://github.com/python/cpython/issues/151365.
run: |
sudo apt-get install -y --allow-downgrades git/noble-updates git-man/noble-updates

vstinner Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I didn't know this /noble-updates syntax. I understand that it's a way to request the git version of Ubuntu 24.04.

vstinner mentioned this pull request Aug 10, 2026
Closed

hugovk commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Is it possible to explicitly declare the version limit in the command, plz?

Something like this?

sudo apt-get install -y --allow-downgrades 'git=1:2.43.*' 'git-man=1:2.43.*'

webknjaz commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@hugovk yep, something along those lines. I was hoping for a <= broken_version.

webknjaz added the 3.15 bugs and security fixes label Aug 10, 2026

vstinner commented Aug 10, 2026

Copy link
Copy Markdown
Member

I suppose that this change should be backported to stable branches (3.13 to 3.15).

webknjaz commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@vstinner I've already labeled it for 3.15, but one of the workflow files doesn't exist in 3.14 so automatic backporting will fail farther back. Once it's ported into 3.15, somebody needs to look into picking it back into older branches manually.

vstinner added the needs backport to 3.15 bugs and security fixes label Aug 10, 2026

vstinner commented Aug 10, 2026

Copy link
Copy Markdown
Member

I've already labeled it for 3.15

The "needs backport to 3.15" label is better for that: it backports automatically the change to 3.15.

hugovk merged commit 6d2b551 into python:main Aug 11, 2026
55 checks passed
hugovk deleted the 3.16-downgrade-git branch August 11, 2026 04:53

miss-islington-app Bot commented Aug 11, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Aug 11, 2026

Copy link
Copy Markdown

GH-155532 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 11, 2026
hugovk added a commit that referenced this pull request Aug 11, 2026
[3.15] gh-151365: Temporarily downgrade Git to prevent fatal error (G…
74da6fb 
…H-155495) (#155532)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Aug 11, 2026
[3.14] gh-151365: Temporarily downgrade Git to prevent fatal error (G…
f420f7c 
…H-155495) (GH-155532) (#155533)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
hugovk added a commit that referenced this pull request Aug 11, 2026
[3.13] gh-151365: Temporarily downgrade Git to prevent fatal error (G…
bec0cbc 
…H-155495) (GH-155532) (GH-155533) (#155535)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Aug 11, 2026
[3.12] gh-151365: Temporarily downgrade Git to prevent fatal error (G…
af5a056 
…H-155495) (GH-155532) (GH-155533) (GH-155535) (#155537)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

webknjaz commented Aug 11, 2026

Copy link
Copy Markdown
Member

@vstinner oops, for some reason I thought I did that but confused the two labels 🤦‍♂️ sry

mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-151365: Temporarily downgrade Git to prevent fatal error (py…
e511781 
…thon#155495)
hugovk pushed a commit that referenced this pull request Aug 29, 2026
gh-151365: Revert temporary Git downgrade (#156584)
3e9efe5 
Revert "gh-151365: Temporarily downgrade Git to prevent fatal error (#155495)"

This reverts commit 6d2b551.
miss-islington mentioned this pull request Aug 29, 2026
Merged
StanFromIreland mentioned this pull request Aug 29, 2026
Merged
hugovk pushed a commit that referenced this pull request Aug 29, 2026
[3.14] gh-151365: Revert temporary Git downgrade (GH-156584) (#156599)
da06c4c 
Revert "gh-151365: Temporarily downgrade Git to prevent fatal error (GH-155495)"

This reverts commit 6d2b551.
(cherry picked from commit 3e9efe5)
This was referenced Aug 29, 2026
Merged
Merged
hugovk pushed a commit that referenced this pull request Aug 30, 2026
[3.13] gh-151365: Revert temporary Git downgrade (GH-156584) (GH-156599…
4ee4734 
…) (#156600)

[3.14] gh-151365: Revert temporary Git downgrade (GH-156584) (GH-156599)

Revert "gh-151365: Temporarily downgrade Git to prevent fatal error (GH-155495)"
(cherry picked from commit da06c4c)


This reverts commit 6d2b551.
(cherry picked from commit 3e9efe5)

Co-authored-by: Stan Ulbrych <stan@python.org>
hugovk pushed a commit that referenced this pull request Aug 30, 2026
[3.12] gh-151365: Revert temporary Git downgrade (GH-156584) (GH-156599…
e114415 
…) (#156601)

[3.14] gh-151365: Revert temporary Git downgrade (GH-156584) (GH-156599)

Revert "gh-151365: Temporarily downgrade Git to prevent fatal error (GH-155495)"
(cherry picked from commit da06c4c)


This reverts commit 6d2b551.
(cherry picked from commit 3e9efe5)

Co-authored-by: Stan Ulbrych <stan@python.org>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
pythongh-151365: Revert temporary Git downgrade (python#156584)
e4b0fe1 
Revert "pythongh-151365: Temporarily downgrade Git to prevent fatal error (python#155495)"

This reverts commit 6d2b551.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
webknjaz webknjaz approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
StanFromIreland StanFromIreland approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
itamaro Awaiting requested review from itamaro itamaro is a code owner
JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee is a code owner

Assignees

No one assigned

Labels

3.15 bugs and security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL