Repository navigation
gh-155499: Allow zero defaults with wide curses borders - #155523
Closed
ahmedtaha100 wants to merge 1 commit into
Closed
ahmedtaha100 wants to merge 1 commit into
ahmedtaha100 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
ahmedtaha100
force-pushed
the
fix/curses-border-zero-defaults
branch
from
f31c46f to
cd478d4
Compare
August 10, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fedonman
Fixes #155499.
border() and box() document 0 as the request for the default character. The wide-character path treated it as a narrow character, so mixing it with a string raised TypeError.
Treat zero like an omitted argument when calling wborder_set(), while continuing to reject nonzero integer or byte characters mixed with wide characters. The tests cover the reported border() call and both box() argument orders.
Tests: