FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141174: Test `get_annotations()` on wrapped cyclical `functools.partial` by dr-carlos · Pull Request #155663 · python/cpython · GitHub

/ cpython Public

gh-141174: Test get_annotations() on wrapped cyclical functools.partial - #155663

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
dr-carlos:annolib-test-wrapped-partial-cycle
Aug 13, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-141174: Test get_annotations() on wrapped cyclical functools.partial#155663
JelleZijlstra merged 1 commit into
python:mainfrom
dr-carlos:annolib-test-wrapped-partial-cycle

Conversation

dr-carlos commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

There is currently no test in test_annotationlib to get the annotations of a function f which is wrapped by a partial of itself, despite the behaviour being implemented in annotationlib:

cpython/Lib/annotationlib.py

Lines 1054 to 1055 in 025e7d2

if id(candidate) in _seen_ids:
break

This PR adds such a test based on the existing cyclical wrapper tests.

bedevere-app Bot added the tests Tests in the Lib/test dir label Aug 13, 2026
bedevere-app Bot mentioned this pull request Aug 13, 2026
Closed
JelleZijlstra added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 13, 2026
JelleZijlstra enabled auto-merge (squash) August 13, 2026 14:17
JelleZijlstra merged commit 5d3f02a into python:main Aug 13, 2026
62 checks passed

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155709 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 13, 2026

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155710 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2026
JelleZijlstra pushed a commit that referenced this pull request Aug 13, 2026
[3.14] gh-141174: Test get_annotations() on wrapped cyclical `funct…
5477222 
…ools.partial` (GH-155663) (#155710)

gh-141174: Test `get_annotations()` on wrapped cyclical `functools.partial` (GH-155663)

Test `get_annotations()` on wrapped cyclical `functools.partial`
(cherry picked from commit 5d3f02a)

Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-141174: Test get_annotations() on wrapped cyclical `functo…
8dd40b9 
…ols.partial` (python#155663)

Test `get_annotations()` on wrapped cyclical `functools.partial`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL