Repository navigation
[3.15] gh-150449: Raise ValueError for sqlite3.Blob slices with a negative step - #155773
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…tive step Reading or writing such a slice computed a negative length and failed with SystemError. Empty slices, which select nothing, are still allowed. (cherry picked from commit d9e8d226a3d05ea020256086aee24d21f9792206)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading or writing a Blob slice with a negative step computed a negative length and failed with SystemError, which means an internal error.
It now raises ValueError.
Empty slices, which select nothing, are still allowed: blob[3:8:-1] returns b"" and assigning b"" to it is a no-op.
Support for negative steps is added in 3.16 by GH-150450.