Repository navigation
gh-155966: Correct handling of math.tanpi poles - #155980
Merged
picnixz merged 10 commits intoSep 9, 2026
Merged
picnixz merged 10 commits into
picnixz merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
As pointed out in the issue, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly. Now, these raise ValueError and this is tested by `test.test_math` through its list of test cases.
skirpichev
requested changes
Aug 18, 2026
Comment thread
Misc/NEWS.d/next/Library/2026-08-17-17-39-41.gh-issue-155966.0YOADY.rst
Outdated
Comment thread
Lib/test/mathdata/math_testcases.txt
Outdated
Comment thread
Lib/test/mathdata/math_testcases.txt
Outdated
…YOADY.rst Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
the test harness cannot verify the sign of infinity, it can only verify the exception; but it's good for it to be correct anyhow.
This reverts commit faa1799.
skirpichev
approved these changes
Aug 18, 2026
mdickinson
reviewed
Aug 18, 2026
Comment thread
Lib/test/mathdata/math_testcases.txt
Outdated
skirpichev
reviewed
Aug 18, 2026
Comment thread
Lib/test/mathdata/math_testcases.txt
Outdated
Copy link
Copy Markdown
Member
|
Mildly off-topic: in case anyone's interested, there's some fun reading here: https://grouper.ieee.org/groups/msc/ANSI_IEEE-Std-754-2019/background/tanpi.txt |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for the changes! LGTM (FWTW) |
Sorry, something went wrong.
picnixz
approved these changes
Aug 21, 2026
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry I forgot to approve!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I forgot that Mark relinquished his commit bit |
Sorry, something went wrong.
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Sep 10, 2026
* main: (158 commits) pythongh-156924: Try reifying lazy imports in `ForwarRef.evaluate()` (python#156940) pythongh-156233: Fix typos and code snippet errors in the docs (python#156475) pythongh-156837: Refer to yield expressions in generator function definitions (pythonGH-156863) pythongh-155292: Skip updating unicodedata with mismatched interpreter (pythonGH-157066) pythongh-157170: Document the scope of global curses settings (pythonGH-157207) pythongh-155966: Correct handling of `math.tanpi` poles (python#155980) pythongh-157170: Restore use_env() after test_use_prescr_screen in test_curses (pythonGH-157171) pythongh-156910: fix deadlock in type_set_abstractmethods under free-threading (python#156948) pythongh-155648: Write the empty and placeholder IDLE tests (python#156260) pythongh-153569: centralize formatted-string state and source spans (python#156484) pythongh-157137: Mark the PEP 820 soft deprecations as 3.15, not `next` (python#157138) pythongh-152433: Use regular LoadLibrary in UWP for Windows system libs (pythonGH-156972) pythongh-121617: Fix Py_CLEAR() memcpy in C++: replace NULL with _Py_NULL (python#157188) pythongh-157135: Fix documentation errors in the `math.atan{2}pi` functions (python#157136) pythongh-121617: Fix Py_CLEAR() in C++: replace NULL with _Py_NULL (python#157067) pythongh-156774: Speed up pdb startup with asyncio guard (python#156775) pythongh-156109: Allow static, non-framework iOS builds (python#156110) pythongh-156780: Emscripten: add missing EM_JS_DEPS (python#156798) pythongh-152936: Make privileged functions available on Android (python#152977) pythongh-123018: Keep the libedit history file header when truncating (pythonGH-157165) ...
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Sep 12, 2026
``math.tanpi`` now raises a ``ValueError`` for half-integer values (e.g., ``tanpi(0.5)``), as these are poles of the function.
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
``math.tanpi`` now raises a ``ValueError`` for half-integer values (e.g., ``tanpi(0.5)``), as these are poles of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #155966, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly.
Now, these raise ValueError and this is tested by test.test_math through its list of test cases.
In the process of working on this, I noticed that I had incorrectly added duplicate test ids and that this was not treated as an error by the test harness. I have corrected this and made it part of the test.