PC/pyconfig.h: improve implicit linking code readibility - #155995
Merged
zooba merged 2 commits intoAug 18, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zooba
reviewed
Aug 18, 2026
Comment thread
PC/pyconfig.h
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zooba
Applying pyconfig.h readability improvements, no functional changes. Moved Py_NO_LINK_LIB check and the explaining comment to the block's header, so it will be possible to understand what this block is about without reading through details and several other defs.
Similar changes are suggested by Steve in this PR review - #19740 (review)
I also tried to remove excessive indentation as suggested in the comment (converting it from 8 spaces to 4, see 353d122), but it creates too much diff, doesn't seem worth it. So skipping it in the PR.