FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix various issues in the 'Timer File Descriptors' documentation by osandov · Pull Request #156027 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Fix various issues in the 'Timer File Descriptors' documentation - #156027

Merged
StanFromIreland merged 6 commits into
python:mainfrom
osandov:timerfd-settime-doc
Aug 25, 2026
ConversationCommits (6)ChecksFiles changed
Merged

Fix various issues in the 'Timer File Descriptors' documentation#156027
StanFromIreland merged 6 commits into
python:mainfrom
osandov:timerfd-settime-doc

Conversation

osandov commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Document the correct default of 0 (based on the clinic input and os.timerfd_settime_ns()).

Fix os.timerfd_settime() flags default argument doc typo
fb180da 
Document the correct default of 0 (based on the clinic input and
os.timerfd_settime_ns()).
bedevere-app Bot added docs Documentation in the Doc dir skip news labels Aug 18, 2026
github-project-automation Bot moved this to Todo in Docs PRs Aug 18, 2026

read-the-docs-community Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34223994 | 📁 Comparing 2f0a97e against main (af49df9)

  🔍 Preview build  

25 files changed · + 1 added · ± 24 modified

+ Added

± Modified

StanFromIreland changed the title Fix os.timerfd_settime() flags default argument doc typo Fix various issues in the os.timerfd_settime{_ns}() documentation Aug 19, 2026
StanFromIreland changed the title Fix various issues in the os.timerfd_settime{_ns}() documentation Fix various issues in the 'Timer File Descriptors' documentation Aug 19, 2026

StanFromIreland commented Aug 19, 2026

Copy link
Copy Markdown
Member

I fixed a few additional issues, @vstinner can you please take a look?

Fix return tuple order in os.timerfd_gettime*() docstring
5edac05 
The reST docs have it right, but it's backwards in the docstring.

osandov commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

I found and fixed one more issue.

StanFromIreland approved these changes Aug 19, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 25, 2026
StanFromIreland merged commit 13ab4c2 into python:main Aug 25, 2026
54 checks passed

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @osandov for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

github-project-automation Bot moved this from Todo to Done in Docs PRs Aug 25, 2026

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @osandov and @StanFromIreland, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 13ab4c2861442f3c558abdb5971716261bf15964 3.15

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @osandov and @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 13ab4c2861442f3c558abdb5971716261bf15964 3.14

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @osandov and @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 13ab4c2861442f3c558abdb5971716261bf15964 3.13

StanFromIreland commented Aug 25, 2026

Copy link
Copy Markdown
Member

Merged, thanks!

@osandov would you be able to do the backports? See the devguide for some instructions.

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156479 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 27, 2026

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156480 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 27, 2026

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156481 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 27, 2026
StanFromIreland added a commit that referenced this pull request Aug 27, 2026
[3.13] Fix various issues in the 'Timer File Descriptors' documentati…
c6d191d 
…on (GH-156027) (#156480)

(cherry picked from commit 13ab4c2)

Co-authored-by: Omar Sandoval <osandov@osandov.com>
StanFromIreland added a commit that referenced this pull request Aug 27, 2026
[3.14] Fix various issues in the 'Timer File Descriptors' documentati…
0bf3b71 
…on (GH-156027) (#156481)

(cherry picked from commit 13ab4c2)

Co-authored-by: Omar Sandoval <osandov@osandov.com>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Aug 27, 2026
Fix various issues in the 'Timer File Descriptors' documentation (pyt…
091f338 
…hon#156027)

Co-authored-by: Stan Ulbrych <stan@python.org>

vstinner commented Aug 31, 2026

Copy link
Copy Markdown
Member

Thanks for the fix.

encukou pushed a commit that referenced this pull request Oct 9, 2026
[3.15] Fix various issues in the 'Timer File Descriptors' documentati…
ee0646e 
…on (GH-156027) (GH-156479)

(cherry picked from commit 13ab4c2)

Co-authored-by: Omar Sandoval <osandov@osandov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes
vstinner Awaiting requested review from vstinner

Assignees

StanFromIreland

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL