Repository navigation
gh-156026: document tar filter link targets - #156056
Merged
ethanfurman merged 1 commit intoOct 12, 2026
Merged
ethanfurman merged 1 commit into
ethanfurman merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Documentation build overview1 file changed ± library/tarfile.html |
Sorry, something went wrong.
ethanfurman
approved these changes
Aug 31, 2026
Copy link
Copy Markdown
Member
|
I think this is much too wordy; see #159019. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the behavior of the tar extraction filter when handling
symbolic-link targets.
tar_filter protects against archive member paths escaping the extraction
destination, but it does not check TarInfo.linkname. As a result, symbolic
links with absolute targets or relative targets outside the destination are
not rejected by this filter.
This change clarifies that behavior in the tar filter documentation and
the tar_filter section.
The stricter data_filter behavior is also documented, including the
exceptions raised for unsafe link targets.
No extraction behavior has been changed.
Testing
required dependency installation and the check was not completed.