FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-156070: Fix operator precedence in multiprocessing's batched Windows wait by ekanshul · Pull Request #156071 · python/cpython · GitHub

Repository navigation

Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Lib/multiprocessing/connection.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ def _exhaustive_wait(handles, timeout):
return []
ready.extend(L[i] for i in res)
if res:
L = [h for i, h in enumerate(L) if i > res[0] & i not in res]
L = [h for i, h in enumerate(L) if i > res[0] and i not in res]
timeout = 0
while L:
short_L = L[:60] if len(L) > 60 else L
Expand Down
24 changes: 24 additions & 0 deletions Lib/test/_test_multiprocessing.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -5918,6 +5918,30 @@ def test_neg_timeout(self):
a.close()
b.close()

@unittest.skipUnless(WIN32, "skipped on non-Windows platforms")
def test_exhaustive_wait_more_than_60_handles(self):
import _winapi
from multiprocessing.connection import _exhaustive_wait

# More than 60 handles takes the batched path. Manual reset events
# stay signalled, so the handles the batched wait already reported
# must be dropped from the list that is scanned afterwards.
events = [_winapi.CreateEventW(0, True, False, None)
for _ in range(70)]
self.addCleanup(lambda: [_winapi.CloseHandle(e) for e in events])

# BatchedWaitForMultipleObjects reports the lowest signalled handle
# of each 63 handle batch, so signalling the first event pins the
# first reported index at 0 and spreads the rest over both batches.
chosen = [0, 17, 42, 68]
for i in chosen:
_winapi.SetEvent(events[i])

# A zero timeout is not usable here: the batched wait would report a
# timeout before its worker threads have run.
ready = _exhaustive_wait(events, 10_000)
self.assertEqual(sorted(ready), sorted(events[i] for i in chosen))

#
# Issue 14151: Test invalid family on invalid environment
#
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :func:`multiprocessing.connection.wait` on Windows when waiting on more
than 60 objects: an object that was already ready could be reported more than
once, and other ready objects could be left out of the result.
Loading

Back | FazBrowse Home | New Git URL