FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-156099: Fix a crash when deleting SSLContext.keylog_filename by serhiy-storchaka · Pull Request #156103 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-156099: Fix a crash when deleting SSLContext.keylog_filename - #156103

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:gh-156099-ssl-keylog-delete
Aug 21, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-156099: Fix a crash when deleting SSLContext.keylog_filename#156103
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:gh-156099-ssl-keylog-delete

Conversation

serhiy-storchaka commented Aug 20, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The setter did not check the value for NULL and passed it to Py_fopen().
Deleting the attribute now raises AttributeError, like other attributes of _ssl._SSLContext.

pythongh-156099: Fix a crash when deleting SSLContext.keylog_filename
6684b6d 
The setter did not check the value for NULL and passed it to Py_fopen().
bedevere-app Bot mentioned this pull request Aug 20, 2026
Closed
serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 20, 2026
serhiy-storchaka merged commit 5ebd486 into python:main Aug 21, 2026
102 of 104 checks passed

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

serhiy-storchaka deleted the gh-156099-ssl-keylog-delete branch August 21, 2026 06:36

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ebd4860d3746eaeb890c947799508e1ed4936fe 3.15

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ebd4860d3746eaeb890c947799508e1ed4936fe 3.14

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ebd4860d3746eaeb890c947799508e1ed4936fe 3.13

This was referenced Aug 21, 2026
Merged
Merged
Merged

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156148 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 21, 2026

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156149 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 21, 2026

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156150 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 21, 2026
serhiy-storchaka added a commit that referenced this pull request Aug 21, 2026
[3.14] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (
de386f2 
GH-156103) (GH-156149)

The setter did not check the value for NULL and passed it to Py_fopen().

(cherry picked from commit 5ebd486)
serhiy-storchaka added a commit that referenced this pull request Aug 21, 2026
[3.13] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (
6b3d4ea 
GH-156103) (GH-156150)

The setter did not check the value for NULL and passed it to Py_fopen().

(cherry picked from commit 5ebd486)
serhiy-storchaka added a commit that referenced this pull request Oct 9, 2026
[3.15] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (
54ffa19 
GH-156103) (GH-156148)

gh-156099: Fix a crash when deleting SSLContext.keylog_filename (GH-156103)

The setter did not check the value for NULL and passed it to Py_fopen().

(cherry picked from commit 5ebd486)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL