Repository navigation
gh-156100: Fix crashes in the sqlite3 Connection.autocommit setter - #156104
Merged
serhiy-storchaka merged 3 commits intoAug 21, 2026
Merged
serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The setter passed the deleted value to autocommit_converter(), which dereferences it.
LEGACY_TRANSACTION_CONTROL is -1, the same value which PyLong_AsLong() returns on error, so the converter reported success with OverflowError set.
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156151 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker daebcac92d422d7fe9611cbe89044af23ea857c3 3.13 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156152 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156155 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter passed the deleted value to autocommit_converter(), which dereferences it in Py_IsTrue().
Deleting the attribute now raises AttributeError, like row_factory and text_factory (gh-149738).
autocommit_converter() also reported success with OverflowError set when the value was an integer which does not fit in C long, because PyLong_AsLong() returns -1 on error, and LEGACY_TRANSACTION_CONTROL is -1.
Such value is now rejected with ValueError, like any other invalid value.