Repository navigation
gh-156124: Fix a crash when deleting ctypes Pointer.contents - #156125
Merged
serhiy-storchaka merged 1 commit intoAug 21, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
In the free-threaded build the setter passed the value to Py_BEGIN_CRITICAL_SECTION2() before checking it for NULL.
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156153 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156154 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointer_set_contents() entered a critical section on the new value before checking it for NULL, so del ptr.contents crashed the free-threaded build. The check is moved ahead of the critical section.