FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-156166: Fix setting and deleting SSLContext._msg_callback by serhiy-storchaka · Pull Request #156167 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-156166: Fix setting and deleting SSLContext._msg_callback - #156167

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-156166-ssl-msg-callback
Aug 21, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-156166: Fix setting and deleting SSLContext._msg_callback#156167
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-156166-ssl-msg-callback

Conversation

serhiy-storchaka commented Aug 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The setter released the old callback before validating the new value, so a failed assignment or a deletion removed it. Deleting the attribute now raises AttributeError, like for keylog_filename.

pythongh-156166: Fix setting and deleting SSLContext._msg_callback
51d184e 
The setter released the old callback before validating the new value,
so a failed assignment or a deletion removed it.
serhiy-storchaka added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 21, 2026
bedevere-app Bot mentioned this pull request Aug 21, 2026
Closed
serhiy-storchaka added the needs backport to 3.13 only security fixes label Aug 21, 2026
serhiy-storchaka enabled auto-merge (squash) August 21, 2026 10:28
serhiy-storchaka merged commit 67f4d53 into python:main Aug 21, 2026
106 of 108 checks passed

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 67f4d53425d4f7df559b4a0ba5bfb66e795854c7 3.14

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156171 is a backport of this pull request to the 3.15 branch.

miss-islington-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 67f4d53425d4f7df559b4a0ba5bfb66e795854c7 3.13

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 21, 2026
serhiy-storchaka deleted the gh-156166-ssl-msg-callback branch August 21, 2026 10:51
This was referenced Aug 21, 2026
Merged
Merged

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156174 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 21, 2026

bedevere-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

GH-156175 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 21, 2026
serhiy-storchaka added a commit that referenced this pull request Aug 21, 2026
[3.14] gh-156166: Fix setting and deleting SSLContext._msg_callback (G…
e810e1a 
…H-156167) (GH-156174)

The setter released the old callback before validating the new value,
so a failed assignment or a deletion removed it.

(cherry picked from commit 67f4d53)
serhiy-storchaka added a commit that referenced this pull request Aug 21, 2026
[3.13] gh-156166: Fix setting and deleting SSLContext._msg_callback (G…
3d937eb 
…H-156167) (GH-156175)

The setter released the old callback before validating the new value,
so a failed assignment or a deletion removed it.

(cherry picked from commit 67f4d53)
serhiy-storchaka added a commit that referenced this pull request Oct 10, 2026
[3.15] gh-156166: Fix setting and deleting SSLContext._msg_callback (G…
27e6e40 
…H-156167) (GH-156171)

The setter released the old callback before validating the new value,
so a failed assignment or a deletion removed it.
(cherry picked from commit 67f4d53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead Awaiting requested review from gpshead gpshead is a code owner
picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL