Repository navigation
[3.13] gh-156106: Add tests for setting and deleting attributes defined in C (GH-156107) - #156191
Merged
serhiy-storchaka merged 3 commits intoAug 21, 2026
Merged
serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…d in C (pythonGH-156107) Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered. (cherry picked from commit cdca502)
serhiy-storchaka
requested review from
1st1,
asvetlov,
erlend-aasland,
gvanrossum,
iritkatriel,
kumaraditya303,
rhettinger and
willingc
as code owners
August 21, 2026 15:08
serhiy-storchaka
enabled auto-merge (squash)
August 21, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #156107 to 3.13.
The tests are adapted to this branch: the tests for _io.TextIOWrapper are in Lib/test/test_io.py, SyntaxError._metadata does not exist, and FileIO._blksize is writable.
The test for deleting frame.f_trace_opcodes is omitted, because it crashes here (gh-156189, #156190).