[3.15] gh-156115: Use the simulator deployment-target flag for iOS simulator builds (GH-156116) - #156211
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-156115: Use the simulator deployment-target flag for iOS simulator builds (GH-156116)#156211miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ulator builds (pythonGH-156116) Ensures that CFLAGS and LDFLAGS use -mios-simulator-version-min, rather than the device-based -mios-version-min. This only matters if the CFLAGS and LDFLAGS are used in a bare call to clang without a -target; but that is a legal usage, so it's worth catching. (cherry picked from commit d856402) Co-authored-by: Clément Péron <peron.clem@gmail.com>
miss-islington
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
August 22, 2026 03:05
This was referenced Aug 22, 2026
freakboy3742
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that CFLAGS and LDFLAGS use -mios-simulator-version-min, rather
than the device-based -mios-version-min. This only matters if the CFLAGS
and LDFLAGS are used in a bare call to clang without a -target; but that is
a legal usage, so it's worth catching.
(cherry picked from commit d856402)
Co-authored-by: Clément Péron peron.clem@gmail.com