gh-127716: make memoryview thread-safe in free-threaded build - #156248
Draft
nascheme wants to merge 1 commit into
Draft
gh-127716: make memoryview thread-safe in free-threaded build#156248nascheme wants to merge 1 commit into
nascheme wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Documentation build overview17 files changed · + 1 added · ± 16 modified + Added ± Modified |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi, thanks for the thorough fix! I read the code and it looks like all operations of the counters are well handled, so I'll close my PR. Also, I checkout your branch and run the reproducers from #127716 and #155606. Both issues appear to be resolved. |
Sorry, something went wrong.
Co-authored-by: ayaangazali <ayaangazali.work@gmail.com> Co-authored-by: Lu Xiaowei <weixlu420302@gmail.com>
nascheme
force-pushed
the
gh-127716-memoryview-thread-safe
branch
from
4269e2d to
8fa2daf
Compare
August 25, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incorporates changes from gh-155882 and gh-154770. It goes further and ensures the underlying buffer remains "pinned" if a thread releases the memory view while other threads have in-flight operations on it.