FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS by advitrocks9 · Pull Request #156302 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS - #156302

Merged
hugovk merged 2 commits into
python:mainfrom
advitrocks9:fix-155193
Aug 25, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS#156302
hugovk merged 2 commits into
python:mainfrom
advitrocks9:fix-155193

Conversation

advitrocks9 commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The 3.15 What's New lists urlsafe_b64decode() as one of the decoders that got canonical, but it never got the parameter:

>>> base64.urlsafe_b64decode(b'aGk=', canonical=True)
TypeError: urlsafe_b64decode() got an unexpected keyword argument 'canonical'

It doesn't call b64decode(), it calls binascii.a2b_base64() directly with a fixed set of arguments, so widening b64decode() in GH-146312 didn't affect it. This drops it from the bullet, per gpshead on the issue.

I went through the other bullets in the base64 section and checked them against the signatures. This is the only one that's off.

The NEWS entry for the same change (now in Misc/NEWS.d/3.15.0b1.rst) says the base16 decoders got canonical, but none did: b16decode() and binascii.a2b_hex() are unchanged. Removed base16 from that entry too.

Docs only, so skip news. Needs a backport to 3.15.

advitrocks9 requested a review from AA-Turner as a code owner August 23, 2026 20:33
bedevere-app Bot added the docs Documentation in the Doc dir label Aug 23, 2026

python-cla-bot Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

github-project-automation Bot moved this to Todo in Docs PRs Aug 23, 2026
bedevere-app Bot mentioned this pull request Aug 23, 2026
Closed

read-the-docs-community Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34196934 | 📁 Comparing c5bf8b9 against main (53d2e14)

  🔍 Preview build  

2 files changed
± whatsnew/3.15.html
± whatsnew/changelog.html

picnixz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Can you check if a NEWS entry needs to be amended as well?

advitrocks9 changed the title gh-155193: Remove urlsafe_b64decode from the *canonical* entry in What's New 3.15 gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS Aug 23, 2026

advitrocks9 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

The NEWS entry doesn't name urlsafe_b64decode(), so it doesn't have the What's New problem. It says base16 got canonical, and it didn't. b16decode() and binascii.a2b_hex() are unchanged, GH-146312 never touched them. Removed base16 from the entry in this PR.

Separately, the binascii bullet in What's New only lists a2b_base64(), but a2b_base32(), a2b_ascii85() and a2b_base85() also got the parameter. Can add them here or in a separate PR.

picnixz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Nah for What's New it's ok.

picnixz requested a review from gpshead August 23, 2026 22:02
gpshead approved these changes Aug 24, 2026
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

good catch on base16 being errantly listed as well.

advitrocks9 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@AA-Turner is this good to be merged?

hugovk merged commit 5f31aee into python:main Aug 25, 2026
34 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Aug 25, 2026
hugovk added the needs backport to 3.15 bugs and security fixes label Aug 25, 2026

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @advitrocks9 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

GH-156370 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 25, 2026
hugovk pushed a commit that referenced this pull request Aug 25, 2026
[3.15] gh-155193: Fix the *canonical* decoder lists in the 3.15 What'…
747e518 
…s New and NEWS (GH-156302) (#156370)

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS (GH-156302)
(cherry picked from commit 5f31aee)

Co-authored-by: Advit Arora <advitarora2@gmail.com>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Aug 27, 2026
pythongh-155193: Fix the *canonical* decoder lists in the 3.15 What's…
4fcf430 
… New and NEWS (python#156302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL