gh-156400: Close the socket or pipe when transport creation fails in asyncio datagram/pipe endpoints - #156401
Open
tonghuaroot wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ls in asyncio datagram/pipe endpoints
tonghuaroot
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 26, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_datagram_endpoint(), connect_read_pipe() and connect_write_pipe() create or take ownership of a socket/pipe and then run protocol_factory() and transport creation. The only cleanup (except: transport.close()) covers await waiter, so if protocol_factory() or _make_*_transport() raises the resource is never closed and leaks until garbage collection.
Close the socket/pipe on that path, matching the create_connection() fix in gh-153133. The added regression tests fail without the fix and pass with it; the full test_asyncio suite passes.